[libvirt] [PATCH] qemu.conf: Change the example user from 'root' to 'qemu'

[Daniel P. Berrangé]

On Fri, Jun 01, 2018 at 02:08:38PM +0200, Kashyap Chamarthy wrote:
> Signed-off-by: Kashyap Chamarthy <kchamart at redhat.com>
> ---
>  src/qemu/qemu.conf | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/src/qemu/qemu.conf b/src/qemu/qemu.conf
> index 31738ff19c..444247cf31 100644
> --- a/src/qemu/qemu.conf
> +++ b/src/qemu/qemu.conf
> @@ -403,13 +403,14 @@
>  #
>  #       user = "qemu"   # A user named "qemu"
>  #       user = "+0"     # Super user (uid=0)
> +#       user = 'root'   # The 'root' user
>  #       user = "100"    # A user named "100" or a user with uid=100
>  #
> -#user = "root"
> +#user = "qemu"
>  
>  # The group for QEMU processes run by the system instance. It can be
>  # specified in a similar way to user.
> -#group = "root"
> +#group = "qemu"
>  
>  # Whether libvirt should dynamically change file ownership
>  # to match the configured user/group above. Defaults to 1.

The reason the config file documents 'root' is because that is what
configure defaults to.  If you pass --with-qemu-user to configure,
we don't update the config file example though, and perhaps we should.

Alternatively should we make configure defualt to 'qemu' instead of
'root', since it is generally considered insane to run QEMU as root.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|