[libvirt] [PATCH 9/9] qemu: command: Refactor disk commandline formatting

Ján Tomko jtomko at redhat.com
Sat Jun 2 15:55:16 UTC 2018


On Fri, Jun 01, 2018 at 05:51:12PM +0200, Peter Krempa wrote:
>Now that we have one place that sets up all disk-related objects to
>qemuBlockStorageSourceAttachDataPtr we can easily reuse the data in the
>command-line formatter by implementing a worker which will convert the
>data.
>
>A huge advantage is that it will be way easier to integrate this with
>-blockdev later on.
>

Sadly, I might not live long enough to see that.

>Signed-off-by: Peter Krempa <pkrempa at redhat.com>
>---
> src/qemu/qemu_command.c | 94 +++++++++++++++++++------------------------------
> src/qemu/qemu_command.h |  3 +-
> src/qemu/qemu_hotplug.c |  3 +-
> 3 files changed, 40 insertions(+), 60 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180602/441a5c7d/attachment-0001.sig>


More information about the libvir-list mailing list