[libvirt] [PATCH v2 1/2] qemu: domain: Forbid storage with old QCOW2 encryption

[Ján Tomko]

On Fri, Jun 01, 2018 at 02:06:37PM +0200, Peter Krempa wrote:
>The encryption was buggy and qemu actually dropped it upstream. Forbid
>it for all versions since it would cause other problems too.
>
>Problems with the old encryption include weak crypto, corruption of
>images with blockjobs and a lot of usability problems.
>
>This requires changing of the encryption type for the encrypted disk
>tests.
>
>Signed-off-by: Peter Krempa <pkrempa at redhat.com>
>---
> docs/formatdomain.html.in                        |  4 ++++
> docs/formatstorageencryption.html.in             |  5 ++---
> src/qemu/qemu_domain.c                           | 10 ++++++++++
> tests/qemuxml2argvdata/encrypted-disk-usage.args |  8 +++++++-
> tests/qemuxml2argvdata/encrypted-disk-usage.xml  |  2 +-
> tests/qemuxml2argvdata/encrypted-disk.args       |  8 +++++++-
> tests/qemuxml2argvdata/encrypted-disk.xml        |  2 +-
> tests/qemuxml2argvtest.c                         |  4 ++--
> tests/qemuxml2xmloutdata/encrypted-disk.xml      |  2 +-
> tests/qemuxml2xmltest.c                          |  4 ++--
> 10 files changed, 37 insertions(+), 12 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180602/1f5f7d78/attachment-0001.sig>