[libvirt] [PATCH] virFileAccessibleAs: Remove redundant forkRet

Radostin Stoyanov rstoyanov1 at gmail.com
Tue Jun 5 07:07:40 UTC 2018


The variable forkRet is not used after commit 25f8781

https://github.com/libvirt/libvirt/commit/25f8781#diff-d2023c1ac4f688aa2021e21cfb60d4f0L1861

Signed-off-by: Radostin Stoyanov <rstoyanov1 at gmail.com>
---
 src/util/virfile.c | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/src/util/virfile.c b/src/util/virfile.c
index 523241f64f..a2c4cebb56 100644
--- a/src/util/virfile.c
+++ b/src/util/virfile.c
@@ -2117,7 +2117,6 @@ virFileAccessibleAs(const char *path, int mode,
 {
     pid_t pid = 0;
     int status, ret = 0;
-    int forkRet = 0;
     gid_t *groups;
     int ngroups;
 
@@ -2152,15 +2151,6 @@ virFileAccessibleAs(const char *path, int mode,
         return 0;
     }
 
-    /* child.
-     * Return positive value here. Parent
-     * will change it to negative one. */
-
-    if (forkRet < 0) {
-        ret = errno;
-        goto childerror;
-    }
-
     if (virSetUIDGID(uid, gid, groups, ngroups) < 0) {
         ret = errno;
         goto childerror;
-- 
2.17.1




More information about the libvir-list mailing list