[libvirt] [PATCH 06/13] qemu: Generate and use zPCI device in QEMU command line

Yi Min Zhao zyimin at linux.ibm.com
Wed Jun 6 08:44:38 UTC 2018



在 2018/6/2 下午10:22, Ján Tomko 写道:
> On Thu, May 24, 2018 at 02:24:31PM +0200, Xiao Feng Ren wrote:
>> From: Yi Min Zhao <zyimin at linux.ibm.com>
>>
>> Add new functions to generate zPCI command string and append it to
>> QEMU command line.
>>
>> Signed-off-by: Yi Min Zhao <zyimin at linux.ibm.com>
>> Reviewed-by: Boris Fiuczynski <fiuczy at linux.vnet.ibm.com>
>> Reviewed-by: Stefan Zimmermann <stzi at linux.ibm.com>
>> Reviewed-by: Bjoern Walk <bwalk at linux.vnet.ibm.com>
>> ---
>> src/qemu/qemu_command.c | 104 
>> ++++++++++++++++++++++++++++++++++++++++++++++++
>> src/qemu/qemu_command.h |   4 ++
>> 2 files changed, 108 insertions(+)
>>
>
>> +static int
>> +qemuBuildExtensionCommandLine(virCommandPtr cmd,
>> +                              virQEMUCapsPtr qemuCaps,
>> +                              virDomainDeviceInfoPtr dev)
>> +{
>> +    if (qemuCheckDeviceIsZPCI(dev)) {
>> +        if (!virQEMUCapsGet(qemuCaps, QEMU_CAPS_DEVICE_ZPCI)) {
>> +            virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
>> +                           _("This QEMU doesn't support zpci 
>> devices"));
>> +            return -1;
>> +        }
>
> Even though we have a lot of pre-existing code, qemuBuild* should not be
> reporting errors based on missing caps. That belongs in Validate.
>
> But it's not necessary here, because we would not have set 
> VIR_PCI_ADDRESS_EXTENSION_ZPCI
> otherwise, right?
Yes, sounds reasonable. Until now, as my test, it's doable. But I think 
we need
more test. If it has no problem, I will change this as your comment in next
version. Thanks for your comment!
>
> Jano
>
>> +        return qemuAppendZPCIDevStr(cmd, dev);
>> +    }
>> +
>> +    return 0;
>> +}
>>
>> static int
>> qemuBulildFloppyCommandLineOptions(virCommandPtr cmd,




More information about the libvir-list mailing list