[libvirt] [PATCH] fdstream: Report error from the I/O thread

[Michal Privoznik]

On 06/06/2018 04:15 PM, John Ferlan wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1529059
> 
> Commit id 0fe4aa14 added the thread specific error message
> reporting (or save) to virFDStreamEvent; however, as processing
> goes via virStream{Send|SendHole|Recv} via calls from
> daemonStreamHandle{WriteData|Hole|Read} the last error
> gets reset in the main libvirt API's thus, whatever error
> may have been set as last error will be cleared prior to
> the error paths using it resulting in the generic error
> on the client side.
> 
> For each of the paths that check threadQuit or threadErr,
> check if threadErr was set and set it agian if there isn't
> a last error (e.g. some other failure) set so that the
> message can be provided back to the client.
> 
> Signed-off-by: John Ferlan <jferlan at redhat.com>
> ---
>  src/util/virfdstream.c | 26 ++++++++++++++++++++------
>  1 file changed, 20 insertions(+), 6 deletions(-)

ACK

Michal