[libvirt] [PATCH] storage: minor fix in luks encrypted volume creation

[Ján Tomko]

On Wed, Jun 06, 2018 at 05:41:58PM +0200, Andrea Bolognani wrote:
>On Wed, 2018-06-06 at 17:35 +0200, Ján Tomko wrote:
>> On Wed, Jun 06, 2018 at 05:30:15PM +0200, Andrea Bolognani wrote:
>> > On Wed, 2018-06-06 at 16:54 +0200, Katerina Koukiou wrote:
>[....]
>> > > (see bz 1468422)
>> >
>> > Something like
>> >
>> >  Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1468422
>>
>> Actually, the 'Resolves: ' part is pointless.
>
>I happen to like it because it falls in neatly with the other
>pseudo-headers we use in commit messages, but I will indeed not
>lose any sleep if she ends up omitting it :)

If for some reason the software displaying the commit message does not
make the link clickable, the 'Resolves:' part hurts usability.

Without it, I can triple-click to select the link and paste it into my
browser.

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180606/7db973ef/attachment-0001.sig>