[libvirt] [PATCH 2/4] conf, schema, docs: Add support for TSEG size setting

Ján Tomko jtomko at redhat.com
Thu Jun 7 19:37:31 UTC 2018


On Thu, Jun 07, 2018 at 10:37:41AM +0200, Martin Kletzander wrote:
>TSEG (Top of Memory Segment) is one of many regions that SMM (System Management
>Mode) can occupy.  This one, however is special, because a) most of the SMM code
>lives in TSEG nowadays and b) QEMU just (well, some time ago) added support for
>so called 'extended' TSEG.  The difference to the TSEG implemented in real q35's
>MCH (Memory Controller Hub) is that it can offer one extra size to the guest OS
>apart from the standard TSEG's 1, 2, and 8 MiB and that size can be selected in
>1 MiB increments.  Maximum may vary based on QEMU and is way too big, so we
>don't need to check for the maximum here.  Similarly to the memory size we'll
>leave it to the hypervisor to try satisfying that and giving us an error message
>in case it is not possible.
>
>Signed-off-by: Martin Kletzander <mkletzan at redhat.com>
>---
> docs/formatdomain.html.in           | 48 +++++++++++++++++++++-
> docs/schemas/domaincommon.rng       |  5 +++
> src/conf/domain_conf.c              | 64 ++++++++++++++++++++++++++++-
> src/conf/domain_conf.h              |  3 ++
> tests/genericxml2xmlindata/tseg.xml | 23 +++++++++++
> tests/genericxml2xmltest.c          |  2 +
> 6 files changed, 143 insertions(+), 2 deletions(-)
> create mode 100644 tests/genericxml2xmlindata/tseg.xml
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180607/dc2404c9/attachment-0001.sig>


More information about the libvir-list mailing list