[libvirt] [PATCH 08/10] tests: qemucapabilities: Test commands used to query capabilities

Peter Krempa pkrempa at redhat.com
Fri Jun 8 07:45:30 UTC 2018


On Thu, Jun 07, 2018 at 22:02:06 -0400, John Ferlan wrote:
> 
> 
> On 06/04/2018 09:58 AM, Peter Krempa wrote:
> > Use qemuMonitorTestNewFromFileFull which allows to test commands used
> > along with providing replies. This has two advantages:
> > 
> > 1) It's easier to see which command was used when looking at the files
> > 2) We check that the used commands are actually in the correct order
> > 
> > Signed-off-by: Peter Krempa <pkrempa at redhat.com>
> > ---
> >  tests/qemucapabilitiestest.c | 13 +++++--------
> >  1 file changed, 5 insertions(+), 8 deletions(-)
> > 
> 
> With top of tree this one fails make check, but I assume that has to do
> with changes in files since you posted... perhaps it's a combo of this
> and the previous patch.

Well, it's probably because you also need the next patch (which is
supposed to be squashed into this one) for the tests to pass. I've
separatet it because all the changes were generated by the regeneration
tool. 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180608/6f2264e9/attachment-0001.sig>


More information about the libvir-list mailing list