[libvirt] [jenkins-ci PATCH] Add perl-generators package
Daniel P. Berrangé
berrange at redhat.com
Fri Jun 8 09:45:10 UTC 2018
On Fri, Jun 08, 2018 at 11:41:54AM +0200, Andrea Bolognani wrote:
> On Fri, 2018-06-08 at 09:49 +0100, Daniel P. Berrangé wrote:
> [...]
> > + perl-generators:
> > + default:
> > + Fedora: perl-generators
>
> Sorting is off - this should be further down, after perl-accessors.
>
> Empty entries are only necessary when you have to remove a value
> that was added by a more generic entry; in this case, you can
> leave it out and only have the Fedora entry.
>
> [...]
> > packages:
> > + - perl-generators
> > - perl-Archive-Tar
> > - perl-CPAN-Changes
> > - perl-Module-Build
>
> Sorting is again off.
>
> [...]
> > packages:
> > + - perl-generators
> > - perl-Archive-Tar
> > - perl-Config-Record
> > - perl-Digest
>
> Here too.
>
>
> Regardless of the nits pointed out above, this commit will fix
> the build issue on Fedora but not on CentOS 7, where neither
> perl-generators nor perl-interpreter exist: you need to also
> tweak libvirt-perl's spec so that those packages are only
> required on Fedora.
I sent a patch for that yesterday....
https://www.redhat.com/archives/libvir-list/2018-June/msg00540.html
>
> Since that needs to be fixed in a different repository, though,
> once you have addressed all of the above you can consider this
> patch
>
> Reviewed-by: Andrea Bolognani <abologna at redhat.com>
>
> --
> Andrea Bolognani / Red Hat / Virtualization
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
More information about the libvir-list
mailing list