[libvirt] [PATCH] qemu: Fixing uninitialised variable inside virQEMUDriverConfigLoadFile.

Peter Krempa pkrempa at redhat.com
Mon Jun 11 06:21:03 UTC 2018


On Fri, Jun 08, 2018 at 17:11:55 -0300, Julio Faracco wrote:
> Since virConfGetValueBool() can return earlier, the parameter 'value'
> might be not initialised properly inside this method. Another proof:

Yeah, the problem is that if the value is not found, virConfGetValueBool
returns 0 which I did not notice.

I think a better fix will be to execute the condition checking 'tmp' only
when virConfGetValueBool returns 1 as we care only if the user set the
unsupported configuration.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180611/0dea9191/attachment-0001.sig>


More information about the libvir-list mailing list