[libvirt] [PATCH v2] qemu: Fixing uninitialised variable inside virQEMUDriverConfigLoadFile.

Ján Tomko jtomko at redhat.com
Tue Jun 12 08:10:12 UTC 2018


To save precious space in the commit summary:
s/Fixing/fix/
s/inside/in/

And most importantly, I deleted the period at the end.

On Mon, Jun 11, 2018 at 05:35:33PM -0300, Julio Faracco wrote:
>Since virConfGetValueBool() can return earlier, the parameter 'value'
>might be not initialised properly inside this method. Another proof:
>Valgrind is returning this error during the libvirtd daemon startup:
>
>==16199== Conditional jump or move depends on uninitialised value(s)
>==16199==    at 0x27FFFEF4: virQEMUDriverConfigLoadFile (qemu_conf.c:809)
>==16199==    by 0x2807665C: qemuStateInitialize (qemu_driver.c:654)
>==16199==    by 0x5535428: virStateInitialize (libvirt.c:662)
>==16199==    by 0x12AED8: daemonRunStateInit (remote_daemon.c:802)
>==16199==    by 0x536DE18: virThreadHelper (virthread.c:206)
>==16199==    by 0x6CB36DA: start_thread (pthread_create.c:463)
>==16199==    by 0x6FEC88E: clone (clone.S:95)
>
>Signed-off-by: Julio Faracco <jcfaracco at gmail.com>
>---
> src/qemu/qemu_conf.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

And pushed.

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180612/cd002c27/attachment-0001.sig>


More information about the libvir-list mailing list