[libvirt] [RFC v3] external (pull) backup API

Eric Blake eblake at redhat.com
Wed Jun 13 15:23:13 UTC 2018


On 05/17/2018 05:43 PM, Eric Blake wrote:
> Here's my updated counterproposal for a backup API.
> 

> /**
>   * virDomainBackupBegin:
>   * @domain: a domain object
>   * @diskXml: description of storage to utilize and expose during
>   *           the backup, or NULL
>   * @checkpointXml: description of a checkpoint to create, or NULL
>   * @flags: not used yet, pass 0
>   *

Actually, since I'm taking two XML documents, this should really have a 
VIR_DOMAIN_BACKUP_VALIDATE flag for comparison of the XML against the 
schema.


> /**
>   * virDomainCheckpointCreateXML:
>   * @domain: a domain object
>   * @xmlDesc: description of the checkpoint to create
>   * @flags: bitwise-OR of supported virDomainCheckpointCreateFlags
>   *

>   */
> virDomainCheckpointPtr
> virDomainCheckpointCreateXML(virDomainPtr domain, const char *xmlDesc,
>                               unsigned int flags);

Ditto.  And this was copied from virDomainSnapshotCreateXML, which 
should also gain a VALIDATE flag.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org




More information about the libvir-list mailing list