[libvirt] [PATCH] events: Remove ATTRIBUTE_NONNULL for virObjectEventStateQueue[Remote]

Ján Tomko jtomko at redhat.com
Mon Jun 18 06:29:33 UTC 2018


On Fri, Jun 15, 2018 at 03:49:51PM -0400, John Ferlan wrote:
>Commit aad3a0b5f altered virObjectEventStateQueueRemote to move
>the "if (!event) return" call added in the previous commit 031eb8f6
>to virObjectEventStateQueue. Neither commit altered the function
>prototype which used ATTRIBUTE_NONNULL(2).
>
>This caused Coverity build problems. Since @event is now checked,
>just remove the ATTRIBUTE_NONNULL check from both prototypes.
>
>Signed-off-by: John Ferlan <jferlan at redhat.com>
>---
> src/conf/object_event.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Although a Coverity build breaker, that doesn't affect everyone so
> I'll wait for R-By or ACK for push.
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180618/e5195395/attachment-0001.sig>


More information about the libvir-list mailing list