[libvirt] [dbus PATCH 01/14] Introduce NodeDevice Interface

Pavel Hrdina phrdina at redhat.com
Tue Jun 19 14:06:55 UTC 2018


On Fri, Jun 15, 2018 at 07:03:37PM +0200, Katerina Koukiou wrote:
> Signed-off-by: Katerina Koukiou <kkoukiou at redhat.com>
> ---
>  data/Makefile.am                |  1 +
>  data/org.libvirt.NodeDevice.xml |  7 +++++
>  src/Makefile.am                 |  1 +
>  src/connect.c                   |  6 ++++
>  src/connect.h                   |  1 +
>  src/nodedev.c                   | 65 +++++++++++++++++++++++++++++++++++++++++
>  src/nodedev.h                   |  9 ++++++
>  src/util.c                      | 35 ++++++++++++++++++++++
>  src/util.h                      | 15 ++++++++++
>  9 files changed, 140 insertions(+)
>  create mode 100644 data/org.libvirt.NodeDevice.xml
>  create mode 100644 src/nodedev.c
>  create mode 100644 src/nodedev.h
> 
> diff --git a/data/Makefile.am b/data/Makefile.am
> index 721b874..b3fa614 100644
> --- a/data/Makefile.am
> +++ b/data/Makefile.am
> @@ -22,6 +22,7 @@ interfaces_files = \
>  	org.libvirt.Connect.xml \
>  	org.libvirt.Domain.xml \
>  	org.libvirt.Network.xml \
> +	org.libvirt.NodeDevice.xml \
>          org.libvirt.NWFilter.xml \
>  	org.libvirt.Secret.xml \
>  	org.libvirt.StoragePool.xml \
> diff --git a/data/org.libvirt.NodeDevice.xml b/data/org.libvirt.NodeDevice.xml
> new file mode 100644
> index 0000000..7ca26d0
> --- /dev/null
> +++ b/data/org.libvirt.NodeDevice.xml
> @@ -0,0 +1,7 @@
> +<!DOCTYPE node PUBLIC "-//freedesktop//DTD D-BUS Object Introspection 1.0//EN"
> +"http://www.freedesktop.org/standards/dbus/1.0/introspect.dtd">
> +
> +<node name="/org/libvirt/nodedev">
> +  <interface name="org.libvirt.NodeDevice">
> +  </interface>
> +</node>
> diff --git a/src/Makefile.am b/src/Makefile.am
> index 53d1a23..3ef3472 100644
> --- a/src/Makefile.am
> +++ b/src/Makefile.am
> @@ -10,6 +10,7 @@ DAEMON_SOURCES = \
>  	events.c events.h \
>  	gdbus.c gdbus.h \
>  	network.c network.h \
> +	nodedev.c nodedev.h \
>  	nwfilter.c nwfilter.h \
>  	secret.c secret.h \
>  	storagepool.c storagepool.h \
> diff --git a/src/connect.c b/src/connect.c
> index 4f2bdb6..08898c8 100644
> --- a/src/connect.c
> +++ b/src/connect.c
> @@ -2,6 +2,7 @@
>  #include "domain.h"
>  #include "events.h"
>  #include "network.h"
> +#include "nodedev.h"
>  #include "nwfilter.h"
>  #include "secret.h"
>  #include "storagepool.h"
> @@ -1668,6 +1669,7 @@ virtDBusConnectFree(virtDBusConnect *connect)
>      if (connect->connection)
>          virtDBusConnectClose(connect, TRUE);
>  
> +    g_free(connect->devPath);

I would prefer nodeDevPath.

Reviewed-by: Pavel Hrdina <phrdina at redhat.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180619/448814a0/attachment-0001.sig>


More information about the libvir-list mailing list