[libvirt] [PATCH v3 11/20] nwfilter: convert IP address learning code to virNWFilterBindingDefPtr

[Daniel P. Berrangé]

On Sun, Jun 17, 2018 at 08:28:11AM -0400, John Ferlan wrote:
> 
> 
> On 06/14/2018 08:33 AM, Daniel P. Berrangé wrote:
> > Use the virNWFilterBindingDefPTr struct in the IP address learning code
> > directly.
> > 
> > Reviewed-by: John Ferlan <jferlan at redhat.com>
> > Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>
> > ---
> >  src/nwfilter/nwfilter_gentech_driver.c |   7 +-
> >  src/nwfilter/nwfilter_learnipaddr.c    | 106 +++++++------------------
> >  src/nwfilter/nwfilter_learnipaddr.h    |   7 +-
> >  3 files changed, 32 insertions(+), 88 deletions(-)
> 
> 
> R-By still applies, but please let's...
> 
> > --- a/src/nwfilter/nwfilter_learnipaddr.c
> > +++ b/src/nwfilter/nwfilter_learnipaddr.c
> 
> [...]
> 
> > @@ -737,19 +724,14 @@ learnIPAddressThread(void *arg)
> >   */
> 
> Adjust the comments above here to replace the ifname, linkdev, macaddr,
> filtername, and filterparams with @binding

Ok will do.

> 
> >  int
> >  virNWFilterLearnIPAddress(virNWFilterTechDriverPtr techdriver,
> > -                          const char *ifname,
> > +                          virNWFilterBindingDefPtr binding,
> >                            int ifindex,
> > -                          const char *linkdev,
> > -                          const virMacAddr *macaddr,
> > -                          const char *filtername,
> > -                          virHashTablePtr filterparams,
> >                            virNWFilterDriverStatePtr driver,
> >                            int howDetect)
> 
> [...]

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|