[libvirt] [tck PATCH v2 01/13] scripts: avoid using multicast MAC addresses

[Laine Stump]

(Sorry, I missed these while I was off remodeling)


On 05/21/2018 12:46 PM, Daniel P. Berrangé wrote:
> The leading digit from the MAC address should be an even number
>
> Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>

Reviewed-by: Laine Stump <laine at laine.org>

> ---
>  scripts/domain/215-nic-hotplug-many.t | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/scripts/domain/215-nic-hotplug-many.t b/scripts/domain/215-nic-hotplug-many.t
> index 0270054..eaa282a 100644
> --- a/scripts/domain/215-nic-hotplug-many.t
> +++ b/scripts/domain/215-nic-hotplug-many.t
> @@ -47,9 +47,9 @@ diag "Creating a new transient domain";
>  my $dom;
>  ok_domain(sub { $dom = $conn->create_domain($xml) }, "created transient domain object");
>  
> -my $mac1 = "01:11:22:33:44:55";
> -my $mac2 = "02:11:22:33:44:55";
> -my $mac3 = "03:11:22:33:44:55";
> +my $mac1 = "02:11:22:33:44:55";
> +my $mac2 = "02:12:22:33:44:55";
> +my $mac3 = "02:13:22:33:44:55";

At first I was wondering how these macs ever got in. Then I remembered
that libvirt used to not check for multicast addresses.

>  my $model = "virtio";
>  
>  my $netxml1 = <<EOF;