[libvirt] [PATCH 05/13] qemu: Auto add pci-root for s390/s390x guests

Yi Min Zhao zyimin at linux.ibm.com
Mon Jun 4 06:05:17 UTC 2018



在 2018/6/2 下午10:18, Ján Tomko 写道:
> On Thu, May 24, 2018 at 02:24:30PM +0200, Xiao Feng Ren wrote:
>> From: Yi Min Zhao <zyimin at linux.ibm.com>
>>
>> The pci-root depends on zpci capability. So autogenerate pci-root if
>> zpci exists.
>>
>> Signed-off-by: Yi Min Zhao <zyimin at linux.ibm.com>
>> Reviewed-by: Boris Fiuczynski <fiuczy at linux.vnet.ibm.com>
>> Reviewed-by: Stefan Zimmermann <stzi at linux.ibm.com>
>> Reviewed-by: Bjoern Walk <bwalk at linux.vnet.ibm.com>
>> ---
>> src/qemu/qemu_domain.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
>> index ee676a2789..05136540aa 100644
>> --- a/src/qemu/qemu_domain.c
>> +++ b/src/qemu/qemu_domain.c
>> @@ -3068,6 +3068,7 @@ qemuDomainDefAddDefaultDevices(virDomainDefPtr 
>> def,
>>     case VIR_ARCH_S390X:
>>         addDefaultUSB = false;
>>         addPanicDevice = true;
>> +        addPCIRoot = virQEMUCapsGet(qemuCaps, QEMU_CAPS_DEVICE_ZPCI);
>
> So from a certain QEMU version all the S390 machine types have an
> implicit PCI root?
If zPCI exists, there must be pci root.
>
> Is migration a thing on S390?
I'm not clear with your said. Could you please explain more?
>
> Jano
>
>>         break;
>>
>>     case VIR_ARCH_SPARC:
>> -- 
>> 2.16.3
>>
>> -- 
>> libvir-list mailing list
>> libvir-list at redhat.com
>> https://www.redhat.com/mailman/listinfo/libvir-list




More information about the libvir-list mailing list