[libvirt] [PATCH 5/8] qemu: implement vsock hotplug

Ján Tomko jtomko at redhat.com
Mon Jun 4 18:30:33 UTC 2018


On Mon, Jun 04, 2018 at 12:13:07PM -0400, John Ferlan wrote:
>
>
>On 05/30/2018 10:57 AM, Ján Tomko wrote:
>> Allow hotplugging the vsock device.
>>
>> https://bugzilla.redhat.com/show_bug.cgi?id=1291851
>>
>> Signed-off-by: Ján Tomko <jtomko at redhat.com>
>> ---
>>  src/qemu/qemu_driver.c  |  9 ++++++-
>>  src/qemu/qemu_hotplug.c | 70 +++++++++++++++++++++++++++++++++++++++++++++++++
>>  src/qemu/qemu_hotplug.h |  4 +++
>>  3 files changed, 82 insertions(+), 1 deletion(-)
>>
>
>Why is QEMU_CAPS_DEVICE_VHOST_VSOCK never checked in the command line
>startup code?  Was that forgotten or just felt not needed.
>

Oops, I forgot to add it.

I have sent a separate patch adding it to qemuDomainDeviceDefValidate,
so that both domain startup and (after this series) hotplug will
be able to catch the error.

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180604/9904f101/attachment-0001.sig>


More information about the libvir-list mailing list