[libvirt] [PATCH v3] Loop through all resolved addresses in virNetSocketNewListenTCP

[Olaf Hering]

Am Mon, 4 Jun 2018 21:16:17 +0200
schrieb Ján Tomko <jtomko at redhat.com>:

> On Mon, Jun 04, 2018 at 12:29:37PM +0200, Olaf Hering wrote:
> >-                goto error;
> This skips all errors, not just EADDRNOTAVAIL. Saving the errno here...

Why would any error matter here? Why was that one 'goto error;' ever correct?
There is more cake on the table, no need to stop here.

> >+    if (nsocks == 0) {
> Also, why the use of global errno variable to pass a value within a
> single block?

I have no idea, likely to have a common error available outside the loop.

Another cleanup for pretty error handling could be done.
If anyone really feels it is needed.


Olaf
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 195 bytes
Desc: Digitale Signatur von OpenPGP
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180604/126b4167/attachment-0001.sig>