[libvirt] [jenkins-ci PATCH 2/5] guests: Remove distinction between files and templates

Daniel P. Berrangé berrange at redhat.com
Tue Jun 5 10:37:09 UTC 2018


On Mon, May 21, 2018 at 06:53:24PM +0200, Andrea Bolognani wrote:
> The main difference between files and templates is that the
> former can can be uploaded as-is, while the latter has to
> go through Jinja2 first.
> 
> Since the overhead of template processing is negligible, and
> there's a fair chance we will need to start using templating
> for files that currently don't need it or viceversa, let's
> get rid of the distinction altogether.
> 
> Signed-off-by: Andrea Bolognani <abologna at redhat.com>
> ---
>  guests/tasks/base.yml                                | 12 ++++++------
>  guests/tasks/users.yml                               |  4 ++--
>  .../{files/ccache.conf => templates/ccache.conf.j2}  |  0
>  .../fedora-rawhide-kernel-nodebug.repo.j2}           |  0
>  .../jessie-backports.preferences.j2}                 |  0
>  .../jessie-backports.sources.j2}                     |  0
>  6 files changed, 8 insertions(+), 8 deletions(-)
>  rename guests/{files/ccache.conf => templates/ccache.conf.j2} (100%)
>  rename guests/{files/fedora-rawhide-kernel-nodebug.repo => templates/fedora-rawhide-kernel-nodebug.repo.j2} (100%)
>  rename guests/{files/jessie-backports.preferences => templates/jessie-backports.preferences.j2} (100%)
>  rename guests/{files/jessie-backports.sources => templates/jessie-backports.sources.j2} (100%)

Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|




More information about the libvir-list mailing list