[libvirt] [RFC PATCH 6/6] qemu: Format pseries.cap-hpt-mps on the command line

Andrea Bolognani abologna at redhat.com
Wed Jun 6 10:02:12 UTC 2018


On Wed, 2018-06-06 at 11:14 +1000, David Gibson wrote:
> Personally I think the shift is *more* usable than a raw page size,
> since the latter is inevitably going to involve counting a bunch of
> zeroes to see if it's the number you meant.  Allowing forms like "16M"
> / "16G" could be nicer; not sure if we have existing helper functions
> which will make that easy.

I was indeed thinking about the latter.

> TBH, if the user is already thinking about page sizes at this low
> level, I don't think doing it by shift is much of a stretch.

I disagree that it's such a low level setting that only people who
can do bitwise shifts off the top of their heads will want to
tweak: if it were, then libvirt will probably not need to expose
it in the first place :)

-- 
Andrea Bolognani / Red Hat / Virtualization




More information about the libvir-list mailing list