[libvirt] [RFC PATCH 6/6] qemu: Format pseries.cap-hpt-mps on the command line

Peter Krempa pkrempa at redhat.com
Wed Jun 6 10:04:30 UTC 2018


On Wed, Jun 06, 2018 at 12:02:12 +0200, Andrea Bolognani wrote:
> On Wed, 2018-06-06 at 11:14 +1000, David Gibson wrote:
> > Personally I think the shift is *more* usable than a raw page size,
> > since the latter is inevitably going to involve counting a bunch of
> > zeroes to see if it's the number you meant.  Allowing forms like "16M"
> > / "16G" could be nicer; not sure if we have existing helper functions
> > which will make that easy.
> 
> I was indeed thinking about the latter.
> 
> > TBH, if the user is already thinking about page sizes at this low
> > level, I don't think doing it by shift is much of a stretch.
> 
> I disagree that it's such a low level setting that only people who
> can do bitwise shifts off the top of their heads will want to
> tweak: if it were, then libvirt will probably not need to expose
> it in the first place :)

Well, it will most probably be configured by some policy code from a
upper layer mgmt tool, so I don't think users will actually ever touch
it.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180606/3b2baa01/attachment-0001.sig>


More information about the libvir-list mailing list