[libvirt] [PATCH v1 04/21] util: audit: use VIR_AUTOFREE instead of VIR_FREE for scalar types

Sukrit Bhatnagar skrtbhtngr at gmail.com
Thu Jun 7 19:34:26 UTC 2018


By making use of the GCC's __attribute__((cleanup)) handled by VIR_AUTOFREE
macro, majority of the VIR_FREE calls can be dropped, which in turn leads to
getting rid of most of our cleanup sections.
---
 src/util/viraudit.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/util/viraudit.c b/src/util/viraudit.c
index 0085dc3..a49d458 100644
--- a/src/util/viraudit.c
+++ b/src/util/viraudit.c
@@ -97,7 +97,7 @@ void virAuditSend(virLogSourcePtr source,
                   virAuditRecordType type ATTRIBUTE_UNUSED, bool success,
                   const char *fmt, ...)
 {
-    char *str = NULL;
+    VIR_AUTOFREE(char *) str = NULL;
     va_list args;
 
     /* Duplicate later checks, to short circuit & avoid printf overhead
@@ -144,7 +144,6 @@ void virAuditSend(virLogSourcePtr source,
         }
     }
 #endif
-    VIR_FREE(str);
 }
 
 void virAuditClose(void)
-- 
1.8.3.1




More information about the libvir-list mailing list