[libvirt] [PATCH 03/10] qemu: driver: Remove impossible code path in qemuDomainSnapshotCreateInactiveExternal

Ján Tomko jtomko at redhat.com
Thu Jun 7 21:03:24 UTC 2018


On Mon, Jun 04, 2018 at 10:58:45AM +0200, Peter Krempa wrote:
>Previous patch naively removed all code relevant to disk format
>checking. The semantics now dictate that the format check when creating
>external snapshots is now impossible as we always fill in the format for
>disks in domain definition in the post-parse callback.
>
>Remove the impossible code path.
>
>Signed-off-by: Peter Krempa <pkrempa at redhat.com>
>---
> src/qemu/qemu_driver.c | 16 ++++------------
> 1 file changed, 4 insertions(+), 12 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180607/9e6bb5fe/attachment-0001.sig>


More information about the libvir-list mailing list