[libvirt] [PATCH 2/3] tools: virsh: add command for controling/monitoring resctrl

Wang, Huaqiang huaqiang.wang at intel.com
Tue Jun 12 10:17:30 UTC 2018



> -----Original Message-----
> From: Martin Kletzander [mailto:mkletzan at redhat.com]
> Sent: Monday, June 11, 2018 4:45 PM
> To: Wang, Huaqiang <huaqiang.wang at intel.com>
> Cc: libvir-list at redhat.com; Feng, Shaohe <shaohe.feng at intel.com>; Niu, Bing
> <bing.niu at intel.com>; Ding, Jian-feng <jian-feng.ding at intel.com>; Zang, Rui
> <rui.zang at intel.com>
> Subject: Re: [libvirt] [PATCH 2/3] tools: virsh: add command for
> controling/monitoring resctrl
> 
> On Fri, Jun 08, 2018 at 05:02:18PM +0800, Wang Huaqiang wrote:
> >---
> 
> The subject says 'virsh', but the code does:
> 
> > include/libvirt/libvirt-domain.h    |   9 +++
> > src/conf/domain_conf.c              |  28 +++++++
> > src/conf/domain_conf.h              |   3 +
> 
> something with XML parsing and/or formatting
> 
> > src/driver-hypervisor.h             |   8 ++
> > src/libvirt-domain.c                |  81 +++++++++++++++++++++
> > src/libvirt_public.syms             |   6 ++
> 
> changes som public API?
> 
> > src/qemu/qemu_driver.c              | 141
> ++++++++++++++++++++++++++++++++++++
> > src/qemu/qemu_process.c             |  65 ++++++++++++++++-
> 
> qemu?
> 
> > src/remote/remote_daemon_dispatch.c |  45 ++++++++++++
> > src/remote/remote_driver.c          |   2 +
> > src/remote/remote_protocol.x        |  28 ++++++-
> 
> remote driver?
> 
> > src/remote_protocol-structs         |  12 +++
> > tools/virsh-domain.c                |  74 +++++++++++++++++++
> 
> oh, look, here's the virsh change =)
> 
> Look at the list and check the git log to see how changes are usually split.
> 
> Also see contributor guidelines, mainly for formatting.

Will separate source code and create more reasonable patch serials in the next update. Thanks.




More information about the libvir-list mailing list