[libvirt] [dbus PATCH v2 00/17] StorageVolume APIs

Katerina Koukiou kkoukiou at redhat.com
Thu Jun 14 15:59:36 UTC 2018


Changes from v1:
- Fixes from reviews
- And more:
    * tests: Moved all xml definitions for tests in separate file.
    * tests: Renamed all functions that are not supposed to be run as
      tests, so that they don't have test prefix. I found out that these
      were running as tests, when I added the new function for listing
      the volumes from the test driver. test driver doesn't offer any
      volumes, and the function failed.
    * tests: To get a test volume I created a pytest fixture, which I
      add in the setup of the tests that are manipulating with volumes.
      In this way, the get_test_storage_volume function remained same to
      the similar purpose functions as suggested in the previous review.

Katerina Koukiou (17):
  Introduce StorageVol Interface
  Implement ListStorageVolumes for StoragePool Interface
  test: move XML definition of entities to seperate file
  tests: rename test_* functions which are not tests
  Implement StorageVolCreateXML method for StoragePool Interface
  Implement Name property for StorageVol Interface
  Implement Key property for StorageVol Interface
  Implement Path property for StorageVol Interface
  Implement GetXMLDesc method for StorageVol Interface
  Implement StorageVolLookupByKey method for Connect Interface
  Implement StorageVolLookupByName method for StoragePool Interface
  Implement StorageVolLookupByPath method for Connect Interface
  Implement Resize method for StorageVol Interface
  Implement Wipe method for StorageVol Interface
  Implement GetInfo method for StorageVol Interface
  Implement Delete method for StorageVol Interface
  Implement StorageVolCreateXMLFrom method for StoragePool Interface

 data/Makefile.am                 |   4 +-
 data/org.libvirt.Connect.xml     |  12 ++
 data/org.libvirt.StoragePool.xml |  28 ++++
 data/org.libvirt.StorageVol.xml  |  51 +++++++
 src/Makefile.am                  |   4 +-
 src/connect.c                    |  66 +++++++++
 src/connect.h                    |   1 +
 src/storagepool.c                | 152 ++++++++++++++++++++
 src/storagevol.c                 | 302 +++++++++++++++++++++++++++++++++++++++
 src/storagevol.h                 |   9 ++
 src/util.c                       |  35 +++++
 src/util.h                       |  16 +++
 tests/libvirttest.py             |  37 ++++-
 tests/test_connect.py            |  69 ++++-----
 tests/test_domain.py             |  20 +--
 tests/test_network.py            |  14 +-
 tests/test_storage.py            |  79 ++++++++--
 tests/xmldata.py                 |  47 ++++++
 18 files changed, 871 insertions(+), 75 deletions(-)
 create mode 100644 data/org.libvirt.StorageVol.xml
 create mode 100644 src/storagevol.c
 create mode 100644 src/storagevol.h
 create mode 100644 tests/xmldata.py

-- 
2.15.0




More information about the libvir-list mailing list