[libvirt] [PATCH] qemuDomainDetachDeviceConfig: Don't free device from @dev

Ján Tomko jtomko at redhat.com
Mon Jun 18 06:24:08 UTC 2018


On Fri, Jun 15, 2018 at 04:20:41PM +0200, Michal Privoznik wrote:
>https://bugzilla.redhat.com/show_bug.cgi?id=1591561
>
>For reasons I don't understand my original patch of 75f0fd51124
>freed not only the chardev from domain but also the one from
>passed virDomainDeviceDefPtr. This caused no troubles until now,
>because those two pointers were separate, but after I've
>introduced virDomainDetachDeviceAlias() they became the same
>resulting in double free on detach.
>
>Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
>---
> src/qemu/qemu_driver.c | 2 --
> 1 file changed, 2 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180618/5186446c/attachment-0001.sig>


More information about the libvir-list mailing list