[libvirt] [PATCH 1/4] qemu: Escape commas for qemuBuildChrChardevStr

[John Ferlan]

On 06/18/2018 01:57 PM, Anya Harter wrote:
> Add comma escaping for dev->data.file.path in cases
> VIR_DOMAIN_CHR_TYPE_DEV and VIR_DOMAIN_CHR_TYPE_PIPE.
> 
> Signed-off-by: Anya Harter <aharter at redhat.com>
> ---
>  src/qemu/qemu_command.c                 | 9 +++++----
>  tests/qemuxml2argvdata/name-escape.args | 4 ++++
>  tests/qemuxml2argvdata/name-escape.xml  | 7 +++++++
>  tests/qemuxml2argvtest.c                | 3 ++-
>  4 files changed, 18 insertions(+), 5 deletions(-)
> 

Having tests is awesome! Thanks!

Not sure why the bite size tasks omitted VIR_DOMAIN_CHR_TYPE_FILE too.
If you want to investigate the FILE case that'd be good - just to make
sure we aren't missing any!  I'll still push this as is since it's fine,
but if the FILE needs something it can be added afterwards.

Reviewed-by: John Ferlan <jferlan at redhat.com>

John