[libvirt] [dbus PATCH 05/14] Implement Destroy method for NodeDevice Interface
Pavel Hrdina
phrdina at redhat.com
Tue Jun 19 14:45:14 UTC 2018
On Fri, Jun 15, 2018 at 07:03:41PM +0200, Katerina Koukiou wrote:
> Signed-off-by: Katerina Koukiou <kkoukiou at redhat.com>
> ---
>
> Some note about the test:
>
> 1: The previous test should not use the node_device_create fixture introduced here
> for the following reason:
> The fixture is creating the device in the setup of the test since the
> device creation is not supposed to be tested in other tests apart from
> the CreateXML test. Only that test should not have the creation in the
> setup, but in the actual test `call` part.
>
> 2: I didn't create the get_test_node_device function as other entities have
> because ListNodeDevices method is not supported by the test driver
>
> data/org.libvirt.NodeDevice.xml | 4 ++++
> src/nodedev.c | 42 +++++++++++++++++++++++++++++++++++++++++
> tests/Makefile.am | 1 +
> tests/libvirttest.py | 10 ++++++++++
> tests/test_nodedev.py | 31 ++++++++++++++++++++++++++++++
> 5 files changed, 88 insertions(+)
> create mode 100755 tests/test_nodedev.py
Reviewed-by: Pavel Hrdina <phrdina at redhat.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180619/e516b29e/attachment-0001.sig>
More information about the libvir-list
mailing list