[libvirt] [dbus PATCH 3/3] tests: Use AM_TESTS_ENVIRONMENT

Pavel Hrdina phrdina at redhat.com
Thu Jun 21 07:56:00 UTC 2018


On Wed, Jun 20, 2018 at 02:20:29PM +0200, Andrea Bolognani wrote:
> According to the documentation[1], TESTS_ENVIRONMENT
> is reserved for the user, which means we shouldn't be
> using it.
> 
> AM_TESTS_ENVIRONMENT needs to be terminated with a
> semicolon, so do that; that requires exporting the
> variables instead of merely declaring them as well.
> 
> [1] https://www.gnu.org/software/automake/manual/html_node/Scripts_002dbased-Testsuites.html
> 
> Signed-off-by: Andrea Bolognani <abologna at redhat.com>
> ---
>  tests/Makefile.am | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/Makefile.am b/tests/Makefile.am
> index 81cb263..e27a24a 100644
> --- a/tests/Makefile.am
> +++ b/tests/Makefile.am
> @@ -36,5 +36,5 @@ EXTRA_DIST = \
>  
>  TESTS = $(test_programs)
>  
> -TESTS_ENVIRONMENT = \
> -	VIRT_DBUS_INTERFACES_DIR=$(abs_top_builddir)/data
> +AM_TESTS_ENVIRONMENT = \
> +	export VIRT_DBUS_INTERFACES_DIR=$(abs_top_builddir)/data;

This will need to be modified to cover the original environment
variables but otherwise looks good.

Pavel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180621/3ea7ec1d/attachment-0001.sig>


More information about the libvir-list mailing list