[libvirt] [dbus PATCH v2 5/5] tests: Use AM_TESTS_ENVIRONMENT

Andrea Bolognani abologna at redhat.com
Thu Jun 21 11:04:59 UTC 2018


According to the documentation[1], TESTS_ENVIRONMENT is
reserved for the user, which means we shouldn't be using it.

AM_TESTS_ENVIRONMENT needs to be terminated with a
semicolon, which in turn requires exporting the variables
instead of merely declaring them, so do both of those
things; since we're rewriting the whole hunk anyway, we
also take the opportunity use proper quoting.

[1] https://www.gnu.org/software/automake/manual/html_node/Scripts_002dbased-Testsuites.html

Signed-off-by: Andrea Bolognani <abologna at redhat.com>
---
 tests/Makefile.am | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tests/Makefile.am b/tests/Makefile.am
index 3872d7b..1fc240b 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -37,6 +37,6 @@ EXTRA_DIST = \
 
 TESTS = $(test_programs)
 
-TESTS_ENVIRONMENT = \
-	abs_top_builddir=$(abs_top_builddir) \
-	VIRT_DBUS_INTERFACES_DIR=$(abs_top_srcdir)/data
+AM_TESTS_ENVIRONMENT = \
+	export abs_top_builddir="$(abs_top_builddir)"; \
+	export VIRT_DBUS_INTERFACES_DIR="$(abs_top_srcdir)/data";
-- 
2.17.1




More information about the libvir-list mailing list