[libvirt] [PATCH v4 6/6] nwfilter: convert virt drivers to use public API for nwfilter bindings

[John Ferlan]

On 06/26/2018 06:23 AM, Daniel P. Berrangé wrote:
> Remove the callbacks that the nwfilter driver registers with the domain
> object config layer. Instead make the current helper methods call into
> the public API for creating/deleting nwfilter bindings.
> 
> Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>
> ---
>  src/conf/domain_nwfilter.c             | 135 +++++++++++++++++++++----
>  src/conf/domain_nwfilter.h             |  16 +--
>  src/libvirt_private.syms               |   1 -
>  src/lxc/lxc_process.c                  |   2 +-
>  src/nwfilter/nwfilter_driver.c         |  82 +++------------
>  src/nwfilter/nwfilter_gentech_driver.c |  42 --------
>  src/nwfilter/nwfilter_gentech_driver.h |   4 -
>  src/qemu/qemu_hotplug.c                |   4 +-
>  src/qemu/qemu_interface.c              |   4 +-
>  src/qemu/qemu_process.c                |   6 +-
>  src/remote/remote_daemon.c             |   1 +
>  src/uml/uml_conf.c                     |   2 +-
>  12 files changed, 142 insertions(+), 157 deletions(-)
> 

My CPU's were kept quite busy during the avocado tests and the
environment is a bit fragile - causing a re-run because of bad user on
keyboard |-/. But I got through what was failing before, the aggressive
create/destroy filter while start/stop domain was successful unless it
was too busy smoking the CPU... Visually the code covers the issues I
was seeing before, so

Reviewed-by: John Ferlan <jferlan at redhat.com>

John