[libvirt] [PATCH 0/2] {lxc, util}: Fixing issues with NULL argument for

Daniel P. Berrangé berrange at redhat.com
Wed Jun 27 10:13:37 UTC 2018


On Tue, Jun 26, 2018 at 11:27:55PM -0300, Julio Faracco wrote:
> This serie fixes the argument 'type' of syscall mount(). Valgrind is
> throwing a memory issue when that parameter is NULL. The best option
> to fix this issue is replace NULL to "none" filesystem.

There's no memory problem here. It is valid to pass NULL - the kernel
would rejected it with EINVAL if it was invalid. This is simply a bug
in valgrind, so please update the commit messages to make it clear
we're simply avoiding valgrind bugs, not fixing memory problems.

> 
> Julio Faracco (2):
>   lxc: moving 'type' argument to avoid issues with mount() syscall.
>   util: moving 'type' argument to avoid issues with mount() syscall.
> 
>  src/lxc/lxc_container.c | 26 +++++++++++++-------------
>  src/util/vircgroup.c    |  2 +-
>  2 files changed, 14 insertions(+), 14 deletions(-)
> 
> -- 
> 2.17.1
> 
> --
> libvir-list mailing list
> libvir-list at redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|




More information about the libvir-list mailing list