[libvirt] [PATCH] qemu: domain: update only newly detected images in qemuDomainDetermineDiskChain

Peter Krempa pkrempa at redhat.com
Wed Jun 27 12:03:51 UTC 2018


The processing code which prepares images should be executed really only
for the images which were detected. The code actually tried to update
the last user-specified layer as well. Thankfully we don't do anything
that would be a problem at this point.

Signed-off-by: Peter Krempa <pkrempa at redhat.com>
---
 src/qemu/qemu_domain.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index f8a662f747..0fe9bc4b2a 100644
--- a/src/qemu/qemu_domain.c
+++ b/src/qemu/qemu_domain.c
@@ -8377,7 +8377,7 @@ qemuDomainDetermineDiskChain(virQEMUDriverPtr driver,
     if (virStorageFileGetMetadata(src, uid, gid, report_broken) < 0)
         goto cleanup;

-    for (n = src; virStorageSourceIsBacking(n); n = n->backingStore) {
+    for (n = src->backingStore; virStorageSourceIsBacking(n); n = n->backingStore) {
         if (qemuDomainValidateStorageSource(n, priv->qemuCaps) < 0)
             goto cleanup;

-- 
2.16.2




More information about the libvir-list mailing list