[libvirt] [PATCH] news: Update release notes

[Peter Krempa]

On Thu, Mar 01, 2018 at 15:12:39 +0100, Michal Privoznik wrote:
> On 03/01/2018 02:15 PM, Peter Krempa wrote:
> > On Thu, Mar 01, 2018 at 14:08:29 +0100, Michal Privoznik wrote:
> >> Signed-off-by: --help <mprivozn at redhat.com>
> > 
> > Hmm.
> > 
> >> ---
> >>  docs/news.xml | 102 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> >>  1 file changed, 102 insertions(+)
> >>
> >> diff --git a/docs/news.xml b/docs/news.xml
> >> index 86a0c8d18..53bf9a49c 100644
> >> --- a/docs/news.xml
> >> +++ b/docs/news.xml
> >> @@ -44,6 +44,28 @@
> >>            using the <code>cachetune</code> element in <code>cputune</code>.
> >>          </description>
> >>        </change>
> >> +      <change>
> >> +        <summary>
> >> +          Allow opening secondary drivers
> >> +        </summary>
> >> +        <description>
> >> +          Up until now it was possible to connect to only hypervisor drivers
> >> +          (e.g. qemu:///system, lxc:///, vbox:///system, and so on). The
> >> +          internal drivers (like network driver, node device driver, etc.) were
> >> +          hidden from users and users could use them only indirectly. Starting
> >> +          with this release new connection URIs are accepted. For instance
> >> +          network:///system, storage:///system and so on.
> >> +        </description>
> > 
> > Isn't this an internal change not really used for consumption of
> > clients?
> 
> Not really. Try it yourself:
> 
> virsh -c network:///system net-list --all

Well, that obviously has to work. But it's not exactly useful for
general usage:

$ virsh -c network:///system list --all
error: Failed to list active domains
error: this function is not supported by the connection driver: virConnectNumOfDomains

[...]

> >> +      <change>
> >> +        <summary>
> >> +          src: Enable building with GCC 8.0
> >> +        </summary>
> >> +        <description>
> >> +          GCC 8.0 added more warnings which found some genuine problems with our code.
> >> +        </description>
> > 
> > I'm not sure whether that improved anything. Also wasn't that gcc 7?
> 
> It added a lot of cases into our switches which are now safer. The
> problem with enums in switch() statements is we have to be 100% sure
> value fits into the enum. For instance:
> 
> int x = VIR_DOMAIN_DEVICE_LAST + 1;
> 
> switch ((virDomainDeviceType) x) {
>   ...
> }
> 
> is obviously problematic.

But those are bug fixes and not improvements. In general the code got
uglier since most switches got a 'default' case and an error report
statement.

> And no, it's gcc 8.

Oh right, it's not released yet so I did not find it ...

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180301/5f3da000/attachment-0001.sig>