[libvirt] [tck PATCH 0/2] set CTRL_IP_LEARNING and DHCPSERVER in filter during no-ip-spoofing test

Laine Stump laine at laine.org
Fri Mar 2 02:51:31 UTC 2018


Self-NACK to this series. I found a bug in one of the patches, and
modified the other to be more useful in a couple other places.

I posted a V2 series with the same subject line.

On 02/28/2018 01:30 PM, Laine Stump wrote:
> We've recently discovered two separate bugs that caused libvirt's
> "DHCP Snooping" feature to not work:
>
> https://bugzilla.redhat.com/show_bug.cgi?id=1529338 - libvirt regression
> https://bugzilla.redhat.com/show_bug.cgi?id=1547237 - libpcap regression
>
> Since we didn't have any test suite covering that code, we had the
> embarrassment of learning of it from someone else's QE (RHV/oVirt QE
> at Red Hat).
>
> This series adds the necessary stuff to the test domain config of
> libvirt-tck's "no-ip-spoofing" test to exercise the DHCPSnoop thread.
>
> (There may be a much better way of dealing with a hash-inside-a-hash;
> I am an imbecile at perl, and arrived at this code by trial, error,
> and google searches).





More information about the libvir-list mailing list