[libvirt] [PATCH v2 1/2] qemu: log the crash information for S390
Bjoern Walk
bwalk at linux.vnet.ibm.com
Fri Mar 2 12:27:02 UTC 2018
John Ferlan <jferlan at redhat.com> [2018-03-01, 02:22PM -0500]:
> On 02/27/2018 04:32 AM, Bjoern Walk wrote:
> > + if (VIR_STRDUP(ret->data.s390.reason, reason) < 0) {
> > + virReportOOMError();
> > + goto error;
> > + }
>
> No need for the OOMError as VIR_STRDUP will splat that for you (the
> _QUIET one won't).
>
> I can fix that up before pushing though.
I always forget this. Appreciated and thanks a lot.
--
IBM Systems
Linux on Z & Virtualization Development
------------------------------------------------------------------------
IBM Deutschland Research & Development GmbH
Schönaicher Str. 220, 71032 Böblingen
Phone: +49 7031 16 1819
------------------------------------------------------------------------
Vorsitzende des Aufsichtsrats: Martina Koederitz
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 906 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180302/b228556c/attachment-0001.sig>
More information about the libvir-list
mailing list