[libvirt] [PATCH] conf: set postParseFailed even without ALLOW_POST_PARSE_FAIL

Peter Krempa pkrempa at redhat.com
Fri Mar 2 14:27:01 UTC 2018


On Fri, Mar 02, 2018 at 15:17:55 +0100, Ján Tomko wrote:
> We allow the postParse callbacks to fail for some reasons (missing
> emulator binary) when parsing the configs from /etc/libvirt.
> In that case, def->postParseFailed is set to true and the post
> parse callbacks are re-executed on domain startup.
> 
> However this bool was only set when virDomainDefPostParse was called
> with the ALLOW_POST_PARSE_FAIL flag set. If the callback failed
> again on domain startup, the bool would be reset and subsequent
> startups would not attempt to reexecute the callback.
> 
> Signed-off-by: Ján Tomko <jtomko at redhat.com>
> ---
>  src/conf/domain_conf.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

ACK
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180302/9bf97d20/attachment-0001.sig>


More information about the libvir-list mailing list