[libvirt] [tck PATCH v2 3/4] set CTRL_IP_LEARNING and DHCPSERVER in filter during no-ip-spoofing test

[Daniel P. Berrangé]

On Thu, Mar 01, 2018 at 09:49:59PM -0500, Laine Stump wrote:
> Adding these parameters to the clean-traffic filter causes a
> significant extra piece of code to be executed (a separate thread is
> started up, which uses libpcap to capture DHCP traffic and learn the
> IP address of the guest / test appliance), so let's get some test
> coverage on that code.
> 
> Signed-off-by: Laine Stump <laine at laine.org>
> ---
> 
> Change from V1:
> 
> * set %filterparams to () instead of undef when not specified.  (undef
>   caused a runtime error that I hadn't noticed, since the result was
>   the same)
> 
> * adjust to use NetAddr::IP object instead of string for networkip.
> 
>  lib/Sys/Virt/TCK.pm                   | 11 ++++++++---
>  lib/Sys/Virt/TCK/DomainBuilder.pm     |  8 +++++++-
>  scripts/nwfilter/220-no-ip-spoofing.t | 11 ++++++++++-
>  3 files changed, 25 insertions(+), 5 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|