[libvirt] [PATCH] travis: force install of python2 into $PATH on macOS

[Andrea Bolognani]

On Mon, 2018-03-05 at 12:19 +0000, Daniel P. Berrangé wrote:
> The homebrew formula's ignored Python PEP-0394 recommendations and
> changed the plain python binary in /usr/local/bin to point to Python 3
> instead of Python 2. Python 2 is not even installed into a location that
> is in $PATH by default anymore. The homebrew packages print a message
> to stderr claiming to provide a way to fix this
> 
> [quote]
>   This formula installs a python2 executable to /usr/local/opt/python at 2/bin
> 
>   If you wish to have this formula's python executable in your PATH then add
> 
>   the following to ~/.bash_profile:
> 
>     export PATH="/usr/local/opt/python at 2/libexec/bin:$PATH"
> [/quote]
> 
> When trying to update $PATH are suggested we find out this message is a
> lie and /usr/local/opt/python at 2 does not even exist, instead Python
> seems to end up in /usr/local/Cellar/python at 2/2.7.14_1
> 
> Rather than hardcoding this version specific directory in our travis
> config, we change to run "brew link --force python at 2", to make it create
> symlinks in /usr/local/bin for the python2 binary.
> 
> The original change triggering this problem was
> 
>   https://github.com/Homebrew/homebrew-core/pull/24604#issue-171653084
> 
> There are countless bug reports against homebrew-core that are closed
> without fixes, so it seems they are determined to ignore the Python
> PEP 0394 recommendations on this.

https://www.youtube.com/watch?v=KZh_ouQ8XEw&t=4s

[...]
>  before_install:
> -  - if [ "$TRAVIS_OS_NAME" == "osx" ]; then brew update && brew upgrade && brew install rpcgen yajl xz; fi
> +  - if [ "$TRAVIS_OS_NAME" == "osx" ]; then brew update && brew upgrade && brew install rpcgen yajl xz && brew link --force python at 2 ; fi

Please drop the space between python at 2 and the semicolon.

With that fixed, and assuming you've already performed a
successful test build on Travis,

  Reviewed-by: Andrea Bolognani <abologna at redhat.com>

-- 
Andrea Bolognani / Red Hat / Virtualization