[libvirt] [PATCH] qemu: different declarations for the same method.
Andrea Bolognani
abologna at redhat.com
Mon Mar 12 10:04:19 UTC 2018
On Fri, 2018-03-09 at 00:24 -0300, Julio Faracco wrote:
> Recently, this warning is appearing while libvirt is being compiled:
> Function 'qemuAssignDeviceDiskAlias' argument order different:
> declaration 'vmdef, def' definition 'def, disk'
>
> This commit change the default declaration for qemuAssignDeviceDiskAlias
> specified at src/qemu/qemu_alias.c.
>
> Signed-off-by: Julio Faracco <jcfaracco at gmail.com>
> ---
> src/qemu/qemu_alias.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/qemu/qemu_alias.h b/src/qemu/qemu_alias.h
> index 2246e712f..8c744138c 100644
> --- a/src/qemu/qemu_alias.h
> +++ b/src/qemu/qemu_alias.h
> @@ -38,8 +38,8 @@ int qemuAssignDeviceControllerAlias(virDomainDefPtr domainDef,
> virQEMUCapsPtr qemuCaps,
> virDomainControllerDefPtr controller);
>
> -int qemuAssignDeviceDiskAlias(virDomainDefPtr vmdef,
> - virDomainDiskDefPtr def);
> +int qemuAssignDeviceDiskAlias(virDomainDefPtr def,
> + virDomainDiskDefPtr disk);
>
> int qemuAssignDeviceHostdevAlias(virDomainDefPtr def,
> char **alias,
I'm not seeing the compiler warning myself, and I know there's some
work going on to make the names of function parameters all nice and
consistent, but in the meantime this is harmless enough so
Reviewed-by: Andrea Bolognani <abologna at redhat.com>
and pushed.
--
Andrea Bolognani / Red Hat / Virtualization
More information about the libvir-list
mailing list