[libvirt] [dbus PATCH 16/18] introduce support for libdbus library

Mon Mar 12 16:30:30 UTC 2018

On Mon, Mar 12, 2018 at 05:21:46PM +0100, Pavel Hrdina wrote:
> We will switch to libdbus library because the systemd sd-bus
> implementation is not thread safe.

Hmmm, libdbus.so isn't all that great with threads either. It has
had countless bugs in its thread support over the years to the
extent that DBus maintainers have actively discouraged people from
using it. GLib didn't even try to use it and wrote new bindings
straight to the socket protocol for this reason.

Personally I think it would be worth considering using glib for
libvirt-dbus. As well as getting access to a nicer DBus binding,
you get to take advantage of higher level APIs that GLib provides
compared to STDC / POSIX. The only real downside of using GLib
is abort-on-OOM behaviour, but I don't think that's an issue for
libvirt-dbus as its just an API shim layer.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|