[libvirt] [PATCH 2/2] qemu: hotplug: Clean up memory backing files after failed memory hotplug

[Ján Tomko]

On Tue, Mar 13, 2018 at 06:36:33PM +0100, Peter Krempa wrote:
>Libvirt provides full path to the backing file since commit
>fec8f9c49afb479f6. This made qemu create the backend object but did not
>delete it. This was fixed for unplug case in 4d83a6722f but not in case
>of failure to hotplug the frontend. We'd leave the files behind which
>would make memory unusable in case of hugepages.
>
>https://bugzilla.redhat.com/show_bug.cgi?id=1553085
>
>Signed-off-by: Peter Krempa <pkrempa at redhat.com>
>---
> src/qemu/qemu_hotplug.c | 4 ++++
> 1 file changed, 4 insertions(+)
>

ACK

>diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c
>index cff40625f8..70325a1246 100644
>--- a/src/qemu/qemu_hotplug.c
>+++ b/src/qemu/qemu_hotplug.c
>@@ -2219,6 +2219,10 @@ qemuDomainAttachMemory(virQEMUDriverPtr driver,
>     if (!mem)
>         goto audit;
>
>+    /* we need to remove the memory backing file so that it does not hog memory */

This comment does not really help with understanding what's happening.
I suggest deleting it since readers will have to read the code anyway.

Jan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180314/a571eb21/attachment-0001.sig>