[libvirt] [PATCH v3 05/12] qemu: Store pr runtime data in status XML

Peter Krempa pkrempa at redhat.com
Thu Mar 15 11:43:59 UTC 2018


On Wed, Mar 14, 2018 at 17:05:34 +0100, Michal Privoznik wrote:
> Now that we generate pr-manager alias and socket path store them
> in status XML so that they are preserved across daemon restarts.
> 
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
>  src/qemu/qemu_domain.c | 108 +++++++++++++++++++++++++++++++++++++++----------
>  1 file changed, 86 insertions(+), 22 deletions(-)
> 
> diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
> index c17e40dc8..d673ddbb2 100644
> --- a/src/qemu/qemu_domain.c
> +++ b/src/qemu/qemu_domain.c
> @@ -1961,28 +1961,6 @@ qemuDomainObjPrivateFree(void *data)
>  }
>  
>  
> -static int
> -qemuStorageSourcePrivateDataParse(xmlXPathContextPtr ctxt,
> -                                  virStorageSourcePtr src)
> -{
> -    if (virStorageSourcePrivateDataParseRelPath(ctxt, src) < 0)
> -        return -1;
> -
> -    return 0;
> -}
> -
> -
> -static int
> -qemuStorageSourcePrivateDataFormat(virStorageSourcePtr src,
> -                                   virBufferPtr buf)
> -{
> -    if (virStorageSourcePrivateDataFormatRelPath(src, buf) < 0)
> -        return -1;
> -
> -    return 0;
> -}

Please don't move these out of here. I've specifically placed them here
since I'll need them way earlier than your patch puts them.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180315/ee740d4a/attachment-0001.sig>


More information about the libvir-list mailing list