[libvirt] [PATCH 10/20] test: rename defaultConn to defaultPrivconn

Marc Hartmayer mhartmay at linux.vnet.ibm.com
Thu Mar 15 16:13:29 UTC 2018


On Thu, Mar 15, 2018 at 03:38 PM +0100, John Ferlan <jferlan at redhat.com> wrote:
> On 03/08/2018 07:20 AM, Marc Hartmayer wrote:
>> Rename the variable @defaultConn to @defaultPrivconn as it doesn't
>> point to a default connection but to the private data used for the
>> shared default connection of the test driver.
>> 
>> Signed-off-by: Marc Hartmayer <mhartmay at linux.vnet.ibm.com>
>> Reviewed-by: Boris Fiuczynski <fiuczy at linux.vnet.ibm.com>
>> ---
>>  src/test/test_driver.c | 10 +++++-----
>>  1 file changed, 5 insertions(+), 5 deletions(-)
>> 
>> diff --git a/src/test/test_driver.c b/src/test/test_driver.c
>> index 5561d0c2ae70..d450be21704e 100644
>> --- a/src/test/test_driver.c
>> +++ b/src/test/test_driver.c
>> @@ -126,7 +126,7 @@ struct _testDriver {
>>  typedef struct _testDriver testDriver;
>>  typedef testDriver *testDriverPtr;
>>  
>> -static testDriverPtr defaultConn;
>> +static testDriverPtr defaultPrivconn;
>
> Probably should be defaultPrivateData then instead since it's assigned
> to conn->privateData...

The naming is “inherited” by the variable 'privconn' :)

>
> (I can change locally before doing any sort of push as long as you agree)...
>
>
> Reviewed-by: John Ferlan <jferlan at redhat.com>
>
> John
>
-- 
Beste Grüße / Kind regards
   Marc Hartmayer

IBM Deutschland Research & Development GmbH
Vorsitzende des Aufsichtsrats: Martina Koederitz
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294





More information about the libvir-list mailing list