[libvirt] [PATCH v2 4/8] python3: Remove uses of string.*() functions

Daniel P. Berrangé berrange at redhat.com
Thu Mar 15 16:36:54 UTC 2018


On Thu, Mar 15, 2018 at 05:11:06PM +0100, Andrea Bolognani wrote:
> All of these have been replaced with methods.
> 
> Signed-off-by: Andrea Bolognani <abologna at redhat.com>
> ---
>  docs/apibuild.py | 142 +++++++++++++++++++++++++++----------------------------
>  1 file changed, 71 insertions(+), 71 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>


> @@ -478,8 +478,8 @@ class CLexer:
>                  return None
>  
>              if line[0] == '#':
> -                self.tokens = map((lambda x: ('preproc', x)),
> -                                  string.split(line))
> +                self.tokens = list(map((lambda x: ('preproc', x)),
> +                                       line.split()))

Nitpick - the list() addition belongs in a later patch


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|




More information about the libvir-list mailing list