[libvirt] [GSoC] Contribution towards GSoC'18 [BiteSizedTasks].

[Martin Kletzander]

On Fri, Mar 16, 2018 at 05:53:01PM +0530, Sukrit Bhatnagar wrote:
>Task: Use comma escaping for more command line values in qemu
>
>Added virQEMUBuildBufferEscapeComma wherever applicable in src/qemu/qemu_command.c as specified in the Task page.
>
>Places where no changes were made:
>- src->hosts->socket in qemuBuildNetworkDriveURI uses virAsprintf not virBufferAsprintf

It could utilize a buffer for that, I'm not sure who supplies the
socket, though.

>- TYPE_DEV, TYPE_FILE, TYPE_PIPE, TYPE_UNIX not found in qemuBuildChrArgStr

I'm not sure what you mean.

>- not applicable on data.nix.path in qemuBuildVhostuserCommandLine

Yeah data.nix.path is not used for the command-line, really, IIUC

>- UNCLEAR: places that use strchr in qemuBuildSmartcardCommandLine, can be converted to use virBufferEscape
>

Probably.  The code is from 2011 so we might've just disallowed that
since it won't probably ever happen.

>All tests which were passed by an unmodified clone were passed after I made these changes.
>Once `make syntax-check` gave a false error related to matching of braces in if-else.
>

Hi, cool that you ran the checks, but you missed some things in the
Coding Guidelines, I guess.  Some of the things (like the way the email
is sent -- missing PATCH) would be solved by setting up the git
send-email command to which Laine already very helpfully replied.  So
that could help you.

I believe the syntax-check error is wrong only due to the exact wording,
but if you check how braces are supposed to be used there really is a
syntax error.

Also check how commit messages (and e-mails with patches) are worded.
What is in the email becomes part of the commit message and if you want
to mention anything else, you can do so under ...

>Your feedback is welcome :)
>
>Signed-off-by: Sukrit Bhatnagar <skrtbhtngr at gmail.com>
>---

... these ^^ three dashes.  Whatever is here does not become part of
the commit message.

Anyway, don't worry about it much, resending and fixing is part of the
whole experience ;)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180316/ddb2bb60/attachment-0001.sig>