[libvirt] [PATCH] qemu: Build usb controller command line more wisely

Ján Tomko jtomko at redhat.com
Fri Mar 16 15:50:58 UTC 2018


On Fri, Mar 16, 2018 at 04:38:14PM +0100, Michal Privoznik wrote:
>https://bugzilla.redhat.com/show_bug.cgi?id=1552127
>
>When building command line for USB controllers we have to do more
>than just put controller's alias onto the command line. QEMU has
>concept of these joined USB controllers. For instance ehci and
>uhci controllers need to create the same USB bus. To achieve that
>the slave controller needs to refer the master controller. This
>worked until we've introduced user aliases because both master
>and slave had the same alias. With user aliases slave can have
>different alias than master. Therefore, when generating command
>line for slave we need to look up the master's alias.
>
>Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
>---
> src/qemu/qemu_command.c                      | 44 ++++++++++++++--
> tests/qemuxml2argvdata/user-aliases-usb.args | 38 ++++++++++++++
> tests/qemuxml2argvdata/user-aliases-usb.xml  | 78 ++++++++++++++++++++++++++++
> tests/qemuxml2argvtest.c                     |  3 ++
> 4 files changed, 158 insertions(+), 5 deletions(-)
> create mode 100644 tests/qemuxml2argvdata/user-aliases-usb.args
> create mode 100644 tests/qemuxml2argvdata/user-aliases-usb.xml
>

ACK

Jan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180316/2f1c48bb/attachment-0001.sig>


More information about the libvir-list mailing list