[libvirt] [PATCH 1/2] apibuild: Fix errors on python3

Cole Robinson crobinso at redhat.com
Fri Mar 16 18:05:11 UTC 2018


Module 'string' function lower doesn't exist in python3. The canonical
way is to call .lower() on a str instance. Do that, and make the
exception handling more specific, which would have made this issue
obvious.

Signed-off-by: Cole Robinson <crobinso at redhat.com>
---
 docs/apibuild.py | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/docs/apibuild.py b/docs/apibuild.py
index 67b7eed1e..e81980e3c 100755
--- a/docs/apibuild.py
+++ b/docs/apibuild.py
@@ -2326,10 +2326,10 @@ class docBuilder:
             for data in ('Summary', 'Description', 'Author'):
                 try:
                     output.write("     <%s>%s</%s>\n" % (
-                                 string.lower(data),
+                                 data.lower(),
                                  escape(dict.info[data]),
-                                 string.lower(data)))
-                except:
+                                 data.lower()))
+                except KeyError:
                     self.warning("Header %s lacks a %s description" % (module, data))
             if 'Description' in dict.info:
                 desc = dict.info['Description']
-- 
2.14.3




More information about the libvir-list mailing list